Sam/ramp constraints #5778
Merged
Sam/ramp constraints #5778
+390
−129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samholmes
force-pushed
the
sam/ramp-constraints
branch
from
c937925 to
63411e6
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
samholmes
force-pushed
the
sam/ramp-constraints
branch
2 times, most recently
from
6f5eed7 to
6c9b34c
Compare
swansontec
requested changes
Oct 16, 2025
src/plugins/ramps/rampConstraints.ts
Outdated
| // Filter out credit for sell in US for Paybis | ||
| if (params.rampPluginId === 'paybis' && params.direction === 'sell') { | ||
| yield params.regionCode.countryCode === 'US' | ||
| } |
There was a problem hiding this comment.
Yeah, it would be clearer as:
const isUsCredit =
direction === 'sell' &&
regionCode.countryCode === 'US' &&
params.paymentType === 'credit'
yield !isUsCreditWhich by DeMorgan's law could also be written:
yield direction !== 'sell' ||
regionCode.countryCode !== 'US' ||
params.paymentType !== 'credit'It's close to what you have, but with || instead of &&. Still, I feel like this inverted version is harder to understand.
samholmes
force-pushed
the
sam/ramp-constraints
branch
from
6c9b34c to
39244b9
Compare
swansontec
approved these changes
Oct 16, 2025
samholmes
force-pushed
the
sam/ramp-constraints
branch
from
39244b9 to
59a12db
Compare
Require `wallet` and use `currencyInfo` to get the `pluginId`.
We're removing `iach` from ramp plugin implementation and deprecating the value for documentation purposes. We'll remove the value variant completely when it's no longer a dependency for legacy code.
We need generators to not early exit on constraints so they're all applied. This is nice so we don't need to couple our constraints to other constrains when adding/removing. The contract is that all the constraints will get equal chance of being applied.
The list of supported countries is copied from the `buyPluginList.json` file. Revolut is not supported for sell direction, so no need to get the country codes from `sellPluginList.json`.
This was missing from the paybisProvider implementation.
The list of supported countries is copied from the `buyPluginList.json` and `sellPluginList.json`.
This may be a temporary constraint, but Paybis does not support sell now.
samholmes
force-pushed
the
sam/ramp-constraints
branch
from
59a12db to
3c951df
Compare
| await request.wallet?.getAddresses({ tokenId: null }) | ||
| )?.[0]?.publicAddress | ||
| await request.wallet.getAddresses({ tokenId: null }) | ||
| )[0].publicAddress |
There was a problem hiding this comment.
Bug: Optional Chaining Removal Causes Runtime Error
Removing optional chaining from the getAddresses() result introduces a potential runtime error. If getAddresses() returns an empty array, accessing [0].publicAddress attempts to read publicAddress from undefined, causing a runtime error. The prior implementation safely returned undefined in this scenario.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Adds a centralized constraint system for ramps, updates request/types to require wallet and use crypto asset structs, and updates providers to honor constraints with minor payment-type fixes.
rampConstraints.tsandutils/constraintUtils.tswithvalidateRampCheckSupportRequest/validateRampQuoteRequestfor global, per-payment rules (ACH/Venmo region limits, Revolut/PayPal country lists, Paybis restrictions).rampPluginTypes.ts:CryptoAssetand use inRampCheckSupportRequest.cryptoAsset.RampQuoteRequest.walletrequired; remove reliance onrequest.pluginIdfor currency plugin id.request.wallet.currencyInfo.pluginId; minor address access fixes.iachwithachin allowed/payment maps; update method maps; apply constraint checks; remove US sell credit filter (handled by constraints).applepay/googlepay) and return multiple quotes; add constraint checks; importPlatform.RampSelectOptionScene: pass correct crypto plugin id fromwallet.currencyInfo.pluginId; remove non-null wallet assertion in approve.fiatPluginTypes.ts: deprecateiach(useach).Written by Cursor Bugbot for commit 3c951df. This will update automatically on new commits. Configure here.